Skip to content
This repository was archived by the owner on Aug 26, 2024. It is now read-only.

Extend djangocms_text_ckeditor #45

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

sounak98
Copy link
Contributor

#Fixes #41

Description

This has extended the toolbar of ckeditor by adding various suitable plugins (Enhanced Image, Youtube and other dependencies). The new toolbar looks like this.

screenshot 2019-02-25 at 12 55 47 pm

After a lot of failed tries to update the ckeditor, I've finally added the plugins to the existing ckeditor version in django_text_ckeditor. This is because the cms plugins in django_text_ckeditor is not compatible with the latest version. They were written for 4.7.3.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Made an article which has both an image and a youtube video. The article is being created and the video and the image are being displayed.

Checklist:

  • My code follows the style guidelines of this project
  • I have not added a commit to any .db files as part of my pull request
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@sounak98
Copy link
Contributor Author

@botanicvelious have a look at this.

@botanicvelious botanicvelious merged commit 5f8be4a into python-gsoc:master Feb 25, 2019
@botanicvelious
Copy link
Collaborator

Looks to work great, merged!

@sounak98 sounak98 deleted the extend-ckeditor branch February 26, 2019 09:35
MastersAbh pushed a commit to MastersAbh/python-blogs that referenced this pull request Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants